Skip to content

Conversation

marco-ippolito
Copy link
Member

Refs: #58588

Should unblock the v20 release

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jun 19, 2025
@marco-ippolito marco-ippolito changed the title test: skip broken sea on rhel8 [v20.x] test: skip broken sea on rhel8 Jun 19, 2025
@panva panva mentioned this pull request Jun 19, 2025
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2025
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

marco-ippolito added a commit that referenced this pull request Jun 20, 2025
PR-URL: #58761
Refs: #58588
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito
Copy link
Member Author

Landed in 850192b

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Jul 1, 2025
PR-URL: nodejs#58761
Refs: nodejs#58588
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Jul 1, 2025
PR-URL: nodejs#58761
Refs: nodejs#58588
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants