Skip to content

test: fix typos in comments and variable names #59330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

test: fix typos in comments and variable names #59330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00e0fb1
test: fix typos
wlgh1553 Aug 2, 2025
67f9d01
test: revert typo fix for ässört.ok in test-assert-first-line.js
wlgh1553 Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-abortsignal-cloneable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('Can create a transferable abort controller', async () => {

mc.port2.postMessage(ac.signal, [ac.signal]);

// Can be cloned/transferd multiple times and they all still work
// Can be cloned/transferred multiple times and they all still work
mc.port2.postMessage(ac.signal, [ac.signal]);

// Although we're using transfer semantics, the local AbortSignal
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-abortsignal-drop-settled-signals.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,17 @@ const limit = 10_000;

describe('when there is a long-lived signal', () => {
it('drops settled dependant signals', (t, done) => {
makeSubsequentCalls(limit, (signal, depandantSignalsKey) => {
makeSubsequentCalls(limit, (signal, dependantSignalsKey) => {
setImmediate(() => {
t.assert.strictEqual(signal[depandantSignalsKey].size, 0);
t.assert.strictEqual(signal[dependantSignalsKey].size, 0);
done();
});
});
});

it('keeps all active dependant signals', (t, done) => {
makeSubsequentCalls(limit, (signal, depandantSignalsKey) => {
t.assert.strictEqual(signal[depandantSignalsKey].size, limit);
makeSubsequentCalls(limit, (signal, dependantSignalsKey) => {
t.assert.strictEqual(signal[dependantSignalsKey].size, limit);

done();
}, true);
Expand Down
Loading