quic: continuing work on impl using openssl 3.5 #59342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
3945b79 to
0eb9341
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
0eb9341 to
aed4e26
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
aed4e26 to
8563b9e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
8563b9e to
876e0ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Handful of relevant CI failures to investigate, mostly related to the cases where quic is not available and windows. Will investigate more over the next couple days. |
Qard
approved these changes
Aug 4, 2025
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
2 times, most recently
from
ec1f232 to
88fedd4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
88fedd4 to
bf36277
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
bf36277 to
544db05
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
544db05 to
7aefdcb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Will need to tweak the handling of the flags a bit more |
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
7aefdcb to
2cb01ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
2cb01ef to
b14212d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Ethan-Arrowood
approved these changes
Aug 11, 2025
3 tasks
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
While I get that macros aren't the most loved thing in the world, they do help reduce boilerplate, and there's a lot of boilerplate in the QUIC code. This commit cleans up some of that boilerplate, particularly around the use of v8 APIs.
jasnell
force-pushed
the
jasnell/yay-quic-2
branch
from
b14212d to
94d5653
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: James M Snell <[email protected]> PR-URL: #59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
jasnell
added a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: James M Snell <[email protected]> PR-URL: #59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
jasnell
added a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: James M Snell <[email protected]> PR-URL: #59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
jasnell
added a commit
that referenced
this pull request
Sep 8, 2025
While I get that macros aren't the most loved thing in the world, they do help reduce boilerplate, and there's a lot of boilerplate in the QUIC code. This commit cleans up some of that boilerplate, particularly around the use of v8 APIs. PR-URL: #59342 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
|
Landed in 3135477...b4af647 |
targos
added
dont-land-on-v20.x
|
Added dont-land labels because this depends on other PRs like #59249. That said, it would probably be good for maintenance to backport all the quic changes to v24.x, especially if they are behind a compile flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on the implementation