quic: fixup windows coverage compile error #59381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
nodejs-github-bot
added
c++
panva
approved these changes
Aug 6, 2025
gurgunday
approved these changes
Aug 6, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Aug 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Aug 6, 2025
richardlau
approved these changes
Aug 6, 2025
|
Windows CI on Jenkins is crawling... and there's an unrelated flaky failure there that'll I have to re-run once the current run finishes. Otherwise this should be ready to go |
jasnell
added a commit
that referenced
this pull request
Aug 7, 2025
PR-URL: #59381 Fixes: #59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
jasnell
added a commit
that referenced
this pull request
Aug 7, 2025
PR-URL: #59381 Fixes: #59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 24e28c4...c8b64bd |
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added
dont-land-on-v20.x
mete0rfish
pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
mete0rfish
pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59381 Fixes: nodejs#59369 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #59369