stream: replace manual function validation with validateFunction #59529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59529 +/- ##
==========================================
+ Coverage 89.77% 89.87% +0.09%
==========================================
Files 654 657 +3
Lines 192633 193397 +764
Branches 37727 37938 +211
==========================================
+ Hits 172937 173810 +873
+ Misses 12297 12084 -213
- Partials 7399 7503 +104
🚀 New features to boost your workflow:
|
aduh95
reviewed
Aug 19, 2025
There was a problem hiding this comment.
IIRC this was done on purpose so the error message includes AsyncFunction to make it clear those utils support callbacks returning a promise. I'm not against scraping that in the name of consistency, I just wanted to point it out in case that context was not known
Replace repetitive manual function type checking with the existing validateFunction in multiple stream operator functions.
JinhyeokFang
force-pushed
the
jinhyeokfang/validator
branch
from
a5d0a92 to
c4e0bb4
Compare
MattiasBuelens
approved these changes
Aug 19, 2025
lpinca
approved these changes
Aug 19, 2025
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Aug 23, 2025
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eefe3b1 |
targos
pushed a commit
that referenced
this pull request
Sep 4, 2025
Replace repetitive manual function type checking with the existing validateFunction in multiple stream operator functions. PR-URL: #59529 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream: replace manual function validation with validateFunction
Replace repetitive manual function type checking with the existing
validateFunction in multiple stream operator functions.