Skip to content

test: deflake test-http-keep-alive-empty-line #59595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

test: deflake test-http-keep-alive-empty-line #59595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions test/parallel/test-http-keep-alive-empty-line.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import assert from 'node:assert';
import { createServer } from 'node:http';
import { connect } from 'node:net';

// This test ensures that data like an empty line (`\r\n`) recevied by the
// server after a request, does not reset the keep-alive timeout. See
// https://github.com/nodejs/node/issues/58140.

const server = createServer({
connectionsCheckingInterval: 100,
headersTimeout: 100,
Expand All @@ -28,23 +32,24 @@ server.listen(0, () => {
'\r\n'
);

setTimeout(() => {
client.write('\r\n');
}, 100);

let responseBuffer = '';
let response = '';
let responseReceived = false;

client.setEncoding('utf-8');
client.on('data', (chunk) => {
responseBuffer += chunk.toString();
response += chunk;

// Check if we've received the full header (ending with \r\n\r\n)
if (responseBuffer.includes('\r\n\r\n')) {
const statusLine = responseBuffer.split('\r\n')[0];
if (response.includes('\r\n\r\n')) {
responseReceived = true;
const statusLine = response.split('\r\n')[0];
const status = statusLine.split(' ')[1];
assert.strictEqual(status, '404');
client.end();
client.write('\r\n');
}
});
client.on('end', common.mustCall());
client.on('end', common.mustCall(() => {
assert.ok(responseReceived);
}));
});
});
Loading