test: split out hints from test-dns

test/parallel/test-dns-lookup-hints-family.js

@@ -0,0 +1,23 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+
+const dns = require('dns');
+
+function noop() {}
+
+dns.setServers([]);
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', {
+    family: 4,
+    hints: 0
+  }, noop);
+});
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', {
+    family: 6,
+    hints: dns.ADDRCONFIG
+  }, noop);
+});

test/parallel/test-dns-lookup-hints.js

@@ -0,0 +1,51 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+
+const dns = require('dns');
+
+function noop() {}
+
+dns.setServers([]);
+
+/*
+ * Make sure that dns.lookup throws if hints does not represent a valid flag.
+ * (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
+ * - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
+ * - it's different from them bitwise ored.
+ * - it's different from 0.
+ * - it's an odd number different than 1, and thus is invalid, because
+ * flags are either === 1 or even.
+ */
+assert.throws(function() {
+  dns.lookup('www.google.com', { hints: (dns.V4MAPPED | dns.ADDRCONFIG) + 1 },
+    noop);
+});
+
+assert.throws(function() {
+  dns.lookup('www.google.com');
+}, 'invalid arguments: callback must be passed');
+
+assert.throws(function() {
+  dns.lookup('www.google.com', 4);
+}, 'invalid arguments: callback must be passed');
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', 6, noop);
+});
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', {}, noop);
+});
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', {
+    hints: dns.V4MAPPED
+  }, noop);
+});
+
+assert.doesNotThrow(function() {
+  dns.lookup('www.google.com', {
+    hints: dns.ADDRCONFIG | dns.V4MAPPED
+  }, noop);
+});

test/parallel/test-dns.js

@@ -90,62 +90,6 @@ assert.doesNotThrow(function() {
   dns.lookup(NaN, noop);
 });
 
-/*
- * Make sure that dns.lookup throws if hints does not represent a valid flag.
- * (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
- * - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
- * - it's different from them bitwise ored.
- * - it's different from 0.
- * - it's an odd number different than 1, and thus is invalid, because
- * flags are either === 1 or even.
- */
-assert.throws(function() {
-  dns.lookup('www.google.com', { hints: (dns.V4MAPPED | dns.ADDRCONFIG) + 1 },
-    noop);
-});
-
-assert.throws(function() {
-  dns.lookup('www.google.com');
-}, 'invalid arguments: callback must be passed');
-
-assert.throws(function() {
-  dns.lookup('www.google.com', 4);
-}, 'invalid arguments: callback must be passed');
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', 6, noop);
-});
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', {}, noop);
-});
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', {
-    family: 4,
-    hints: 0
-  }, noop);
-});
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', {
-    family: 6,
-    hints: dns.ADDRCONFIG
-  }, noop);
-});
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', {
-    hints: dns.V4MAPPED
-  }, noop);
-});
-
-assert.doesNotThrow(function() {
-  dns.lookup('www.google.com', {
-    hints: dns.ADDRCONFIG | dns.V4MAPPED
-  }, noop);
-});
-
 assert.throws(function() {
   dns.lookupService('0.0.0.0');
 }, /Invalid arguments/);