Skip to content

Conversation

diangogav
Copy link

@diangogav diangogav commented Sep 23, 2025

  • Falsy pattern via SAN: DNS: (triggers if (!pattern) return false)
  • CN array with empty string: CN: ['']
  • Empty label in pattern: bad..example.com (CN and SAN)
  • Non-ASCII/blank label: caf\u00E9.example.com and bad label.com
  • Multiple wildcards in first label: b**.a.com (CN and SAN)
  • Prefix mismatch with single wildcard: ab*cd.a.com vs xbcd.a.com (CN and SAN)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2025
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (4dc19ec) to head (2165341).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59989      +/-   ##
==========================================
- Coverage   88.49%   88.48%   -0.01%     
==========================================
  Files         703      703              
  Lines      207529   207529              
  Branches    40011    40017       +6     
==========================================
- Hits       183643   183629      -14     
+ Misses      15885    15883       -2     
- Partials     8001     8017      +16     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diangogav diangogav closed this Sep 24, 2025
@diangogav diangogav deleted the diangogav/test-tls-check-server-identity-coverage branch September 24, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants