doc: describe child.kill() pitfalls on linux #6052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
child_process
| Note that while the function is called `kill`, the signal delivered to the | ||
| child process may not actually terminate the process. | ||
| child process may not actually terminate the process. E.g. on `linux` child |
There was a problem hiding this comment.
Any reason why linux is inside a code segment here rather than being capitalized? (Linux)
|
@benjamingr did the Linux thing. Thx. |
closes #2098 amend you reference
|
@sam-github Yes. And that was my point also. I have just separated it from the part above paragraph. Wasn't sure whether it was fitting in there. This was meant to clarify exactly that confusion. Hope that is better. |
|
LGTM. |
|
Thanks, landed in 8f4fdc9 |
stevemao
referenced
this pull request
Apr 11, 2016
This commit refines the documentation around child.kill(), where kill attempts against shells will lead to unexpected results. Namely, on linux the child process of a child process will not terminate, when its parent gets terminated. This is different across the the platforms. PR-URL: #2098 Reviewed-By: Benjamin Gruenbaum <[email protected]> Closes: #2098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
docDescription of change
This commit refines the documentation around
child.kill(), where kill attempts against shells will lead to unexpected results. Namely, on linux the child process of a child process will not terminate, when its parent gets terminated. This is different across the the platforms.closes #2098