src: replace ARRAY_SIZE with typesafe arraysize (v4.x) #6221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
thanks @bnoordhuis I'll get this landed in v4 after it lives in v5 for a bit |
|
LGTM. This one should be safe but giving it a week makes sense. |
|
LGTM |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
6291de2 to
a8312f2
Compare
|
@bnoordhuis it looks like this needs to be rebased again. Thanks |
|
one more ping to @bnoordhuis |
|
ping @bnoordhuis |
ESLint 2.9.0 fixes some bugs that resulted in minor issues not being caught by ESLint 2.7.0. Update instances of our code that will be flagged when we upgrade to ESLint 2.9.0. PR-URL: nodejs#6498 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes some formatting, improves some formatting, updates minor nits. Refs: nodejs#6655 PR-URL: nodejs#6548 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Included a block in the modules.md file to explain the existence and purpose of the module wrapper. PR-URL: nodejs#6433 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: nodejs#6681 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
Fixes: nodejs#6642 PR-URL: nodejs#6689 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: nodejs#6682 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noorhduis <[email protected]>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: nodejs#6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: nodejs#6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
PR-URL: nodejs#6812 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Sorry, this has been on my todo list for some time. I'll try to get around to it this week. |
To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
backport-5969-v4.x
branch
from
b46ea50 to
6ddd3d3
Compare
|
Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/2903/ |
|
landed in 8f55108...a8207fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@thealphanerd
CI: https://ci.nodejs.org/job/node-test-pull-request/2277/