Skip to content

test: spawn new processes in vm-cached-data #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions test/parallel/test-vm-cached-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,38 @@
require('../common');
const assert = require('assert');
const vm = require('vm');
const spawnSync = require('child_process').spawnSync;
const Buffer = require('buffer').Buffer;

function getSource(tag) {
return `(function ${tag}() { return \'${tag}\'; })`;
}

function produce(source) {
const script = new vm.Script(source, {
produceCachedData: true
});
assert(!script.cachedDataProduced || script.cachedData instanceof Buffer);
function produce(source, count) {
if (!count)
count = 1;

const out = spawnSync(process.execPath, [ '-e', `
var assert = require('assert');
var vm = require('vm');

let data;
for (var i = 0; i < ${count}; i++) {
var script = new vm.Script(process.argv[1], {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, process.argv[1] === undefined here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, see source on line 32.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ node -e 'console.log(process.argv[1])' hello
hello

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bet you didn't know about this 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed the third argument. Never mind.

produceCachedData: true
});

assert(!script.cachedDataProduced || script.cachedData instanceof Buffer);

if (script.cachedDataProduced)
data = script.cachedData.toString('base64');
}
console.log(data);
`, source]);

assert.equal(out.status, 0, out.stderr + '');

return script.cachedData;
return Buffer.from(out.stdout.toString(), 'base64');
}

function testProduceConsume() {
Expand All @@ -34,9 +53,7 @@ testProduceConsume();
function testProduceMultiple() {
const source = getSource('original');

produce(source);
produce(source);
produce(source);
produce(source, 3);
}
testProduceMultiple();

Expand Down