Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented May 11, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc assert

Description of change

Ref: #6578

@Trott Trott added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels May 11, 2016
@claudiorodriguez
Copy link
Contributor

LGTM

3 similar comments
@jasnell
Copy link
Member

jasnell commented May 11, 2016

LGTM

@r-52
Copy link
Contributor

r-52 commented May 11, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented May 13, 2016

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
PR-URL: nodejs#6688
Ref: nodejs#6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 13, 2016

Landed in f52b2f1

@Trott Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
PR-URL: nodejs#6688
Ref: nodejs#6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott Trott deleted the assertiology branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants