Skip to content

Conversation

italoacasas
Copy link

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for net

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 28, 2016
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label May 28, 2016
@@ -7,35 +7,53 @@ functions for creating both servers and clients (called streams). You can includ
this module with `require('net');`.

## Class: net.Server
<!-- YAML
added: v0.7.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? The docs change in which it was introduced seems to be in 499c615

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap you are right. thanks

@addaleax
Copy link
Member

addaleax commented Jun 1, 2016

Generally looking good, with a few comments… really appreciate the hard work behind this!

@italoacasas
Copy link
Author

italoacasas commented Jun 1, 2016

tomorrow I'm going to check server.listen because is a little bit more harder to find, thanks for the help @addaleax

@addaleax
Copy link
Member

addaleax commented Jun 2, 2016

LGTM

@addaleax addaleax merged commit 8bccc9e into nodejs:master Jun 3, 2016
@addaleax
Copy link
Member

addaleax commented Jun 3, 2016

Merged, thanks for the effort you put into this!

evanlucas pushed a commit that referenced this pull request Jun 15, 2016
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <[email protected]>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants