Backport PR 6575 #7128
Closed
Backport PR 6575 #7128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs: #6575. |
2 tasks
Wait for the `close` event before parsing the child stdout output. Fixes: nodejs#6480 Ref: nodejs#6575 PR-URL: nodejs#7128 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
PR updated with correct metadata |
|
LGTM |
1 similar comment
|
LGTM |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 4, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
landed in 8f55108 |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change