Skip to content

child_process: measure buffer length in bytes #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

child_process: measure buffer length in bytes #7381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c60742e
test: add test for exec() known issue
Trott Jun 22, 2016
0bff9b3
Revert "child_process: measure buffer length in bytes"
Trott Jun 22, 2016
0e3c527
child_process: measure buffer length in bytes
Trott May 14, 2016
3c23f12
squash: test update
Trott Jun 23, 2016
2fe26f0
squash: fix lint
Trott Jun 23, 2016
36942a1
squash: undo merge mistake
Trott Jun 23, 2016
1e429a8
squash: remove incorrect doc change
Trott Jun 23, 2016
b20cb25
squash: lint
Trott Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/child_process/child-process-exec-stdout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');

var messagesLength = [64, 256, 1024, 4096];
const messagesLength = [64, 256, 1024, 4096];
// Windows does not support that long arguments
if (process.platform !== 'win32')
messagesLength.push(32768);
Expand Down
2 changes: 1 addition & 1 deletion benchmark/child_process/child-process-read.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common.js');
const os = require('os');

var messagesLength = [64, 256, 1024, 4096];
const messagesLength = [64, 256, 1024, 4096];
// Windows does not support that long arguments
if (os.platform() !== 'win32')
messagesLength.push(32768);
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-child-process-exec-data-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const exec = require('child_process').exec;

const expectedCalls = 2;

const cb = common.mustCall((data) => {
assert(data instanceof Buffer);
}, expectedCalls);

const command = common.isWindows ? 'dir' : 'ls';
exec(command).stdout.on('data', cb);

exec('fhqwhgads').stderr.on('data', cb);