doc: update node.js references in api docs #750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| processes. In addition to having all the methods in a normal ChildProcess | ||
| instance, the returned object has a communication channel built-in. See | ||
| `child.send(message, [sendHandle])` for details. | ||
|
|
||
| These child Nodes are still whole new instances of V8. Assume at least 30ms | ||
| startup and 10mb memory for each new Node. That is, you cannot create many | ||
| These child io.js's are still whole new instances of V8. Assume at least 30ms |
There was a problem hiding this comment.
Maybe change this to These child io.js processes....
|
A couple tiny nits, but LGTM. |
|
I was wondering about that. Is it still 'an $x' when $x is a product name? |
|
You wouldn't say "a iPhone" |
|
AFAIK, yes it's still |
bnoordhuis
force-pushed
the
fix-issue-740
branch
from
c45469a to
2c330bf
Compare
|
Okay, updated. PTAL. |
bnoordhuis
added a commit
that referenced
this pull request
Feb 7, 2015
Fixes: #740 PR-URL: #750 Reviewed-By: Colin Ihrig <[email protected]>
bnoordhuis
added a commit
that referenced
this pull request
Feb 7, 2015
PR-URL: #750 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: iojs#740
R=@cjihrig?