inspector: Make sure all messages are dispatched #8264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
LGTM but s/Make/make/ in the commit log status line. |
This fixes a race condition when messages are coming while V8 is still dispatching the previous batch.
|
I filed the commit log line. |
|
CI is red, looks like a build bot failure, trying again: https://ci.nodejs.org/job/node-test-pull-request/3896/ |
|
Modulo the expected failure on ubuntu1204-clang341, the CI is green. |
|
Landed as 27fd2d7. |
ofrobots
pushed a commit
that referenced
this pull request
Aug 31, 2016
This fixes a race condition when messages are coming while V8 is still dispatching the previous batch. PR-URL: #8264 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
This fixes a race condition when messages are coming while V8 is still dispatching the previous batch. PR-URL: nodejs#8264 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
This fixes a race condition when messages are coming while V8 is still dispatching the previous batch. PR-URL: #8264 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
This change only touches V8 inspector integration.
Description of change
This fixes a race condition when messages are coming while V8 is still
dispatching the previous batch.
CC: @ofrobots