module: Remove deprecated/unused function requireRepl. Part of #4642 #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
module
AdriVanHoudt
force-pushed
the
remove-requireRepl
branch
from
c44e76d to
6be1333
Compare
|
What's the usage look like in the ecosystem? /cc @ChALkeR |
jasnell
approved these changes
Sep 20, 2016
|
Most of those are LGTM. |
ChALkeR
approved these changes
Sep 23, 2016
bnoordhuis
approved these changes
Sep 23, 2016
|
@bnoordhuis can you point me in the right direction? Not sure what is wrong with the commit log. |
|
See CONTRIBUTING.md in the top-level directory; for example, the first line should be <= 50 characters, links to GH issues should be Refs: or Fixes: tags, etc. |
|
Ah I see, thanks, will update soon |
AdriVanHoudt
force-pushed
the
remove-requireRepl
branch
from
6be1333 to
8a89112
Compare
AdriVanHoudt
force-pushed
the
remove-requireRepl
branch
from
8a89112 to
cd9db93
Compare
|
@bnoordhuis I think it is conform now |
jasnell
pushed a commit
that referenced
this pull request
Oct 7, 2016
Refs: #4642 PR-URL: #8575 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 4d6297f. Thank you! |
|
@nodejs/ctc ... any objections to landing this in v7.x? |
|
No 😉 |
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
Refs: #4642 PR-URL: #8575 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
moduleDescription of change
Remove deprecated/unused function requireRepl.