Skip to content

Conversation

targos
Copy link
Member

@targos targos commented Oct 7, 2016

v4.x backport of #8633
/cc @thealphanerd

Add tests for untested branches and statements.
Change assert.equal to assert.strictEqual for consistency.

PR-URL: nodejs#8633
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@targos targos added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. v4.x labels Oct 7, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v4.x labels Oct 7, 2016
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

landed in 3e6445d thanks @targos

@targos targos deleted the backport-8633-v4.x branch June 1, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants