test: clean up test-child-process-exec-cwd.js
#9231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Trott |
mscdex
added
the
child_process
cjihrig
reviewed
Oct 21, 2016
| @@ -15,5 +15,5 @@ if (common.isWindows) { | |||
|
|
|||
| exec(pwdcommand, {cwd: dir}, common.mustCall(function(err, stdout, stderr) { | |||
| assert.ifError(err); | |||
| assert.ok(stdout.indexOf(dir) == 0); | |||
| assert.ok(stdout.indexOf(dir) === 0); | |||
There was a problem hiding this comment.
This would probably make more sense as assert.strictEqual(stdout.indexOf(dir), 0);
|
Nit: |
jeenalee
force-pushed
the
test-refactor
branch
from
3f36973 to
41e483b
Compare
|
Review comments, including editing commit message, addressed. Thanks everyone! |
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible.
jeenalee
force-pushed
the
test-refactor
branch
from
41e483b to
381a524
Compare
jeenalee
changed the title
test-child-process-exec-cwd.jstest-child-process-exec-cwd.js
lpinca
approved these changes
Oct 24, 2016
jasnell
approved these changes
Oct 24, 2016
|
too much red in that last CI run.. trying again: https://ci.nodejs.org/job/node-test-pull-request/4667/ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 26, 2016
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible. PR-URL: nodejs#9231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
|
Landed in 2d472a3 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 2, 2016
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible. PR-URL: #9231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 18, 2016
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible. PR-URL: #9231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 19, 2016
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible. PR-URL: #9231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
- Changed `assert.ok()` to `assert.strictEqual()`. - Changed `var` to `const` where possible. PR-URL: #9231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This patch provides minor fixes to
test-child-process-exec-cwd.js. Notably:==to===.vartoconstwhere possible.