Skip to content

Conversation

koh110
Copy link
Contributor

@koh110 koh110 commented Nov 12, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

fix the index order in pseudocode of modules.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Nov 12, 2016
Copy link
Contributor

@shigeki shigeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yosuke-furukawa
Copy link
Member

LGTM, but you need to check commit message follows commit guidelines .

fix the index order in pseudocode of modules.
shigeki pushed a commit that referenced this pull request Nov 12, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Nov 12, 2016

This is a trivial change so I landed it right now in f673c97.
Congrats on your first contribution. Thanks.

@shigeki shigeki closed this Nov 12, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
fix the index order in pseudocode of modules.

PR-URL: #9562
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants