test: Modernize test-fs-truncate-fd #9978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous.
imyller
added
the
code-and-learn
|
@NigelKibodeaux Can you please restore standard PR description template. Thank you! |
|
@imyller Sorry, I created the pull request from GitHub Desktop so I wasn't aware of the template. |
|
@NigelKibodeaux No problems. Looks good now! Thank you 👍 |
cjihrig
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous. PR-URL: #9978 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c994567. thank you for the PR and for participating in the code-and-learn! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous. PR-URL: #9978 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous. PR-URL: nodejs#9978 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous. PR-URL: nodejs#9978 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
this test fails when backported to v4.x. Is that the expected behavior? |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- changed `var` to `const` where variables were not reassigned. - changed `assert.equal` to `assert.strictEqual` because there was no downside to being more rigorous. PR-URL: #9978 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
vartoconstwhere variables were not reassigned.assert.equaltoassert.strictEqualbecause there was nodownside to being more rigorous.