Skip to content

Remove English commented out code from translations #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XhmikosR opened this issue Sep 6, 2019 · 9 comments
Closed

Remove English commented out code from translations #2510

XhmikosR opened this issue Sep 6, 2019 · 9 comments

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 6, 2019

It seems it's common practice. We need another way for translators to follow the English files and know up to where they have translated. Maybe a simple HTML comment with the hash and then they can compare after that and see the diff.

Right now, many translations follow this practice which results in ~2x lines. All this does not come for free and it's bloating the codebase IMO.

Also, there's #2450.

@grodd
Copy link
Contributor

grodd commented Sep 15, 2019

Hey! Can you tell me more about this issue?

@nschonni
Copy link
Member

EX: English text is copied into the translated documents like

https://github.com/nodejs/nodejs.org/blame/347682b75702a51d515b307aabd1e4766df55978/locale/ko/about/index.md#L9-L18

So if the English is updated, these are actually out of sync.

@SEWeiTung
Copy link
Contributor

@XhmikosR and @nschonni, I know this so far, it seems this is Korean and Japanese's habit. So we don't need to worry about them.
But in order to be fair, I'd invite @nodejs/nodejs-ko and @nodejs/nodejs-ja to have a discussion about it. If they don't agree with your ideas, I have to close your issue.

@yous
Copy link
Contributor

yous commented Sep 20, 2019

Commenting the corresponding commit hash of English file may work. But transition will take time as it requires re-sync of all translation files. I personally don't have objections to having process transition. But I have to listen how @nodejs/nodejs-ko think.

@XhmikosR
Copy link
Contributor Author

It's also a habit in pt_BR, at least in some files.

@alexandrtovmach
Copy link
Contributor

We decided to go with CrowdIn approach here nodejs/i18n#72 and I'm now working on configuring it, so this issue will be fixed in near future.

@XhmikosR
Copy link
Contributor Author

@nschonni I haven't followed the translations on his repo so if this is sorted or if it will be sorted, feel free to close this issue.

@nschonni
Copy link
Member

Crowdin is hooked up now, but it's not really used. Primarily the changes comes as PRs to the repo

@ovflowd
Copy link
Member

ovflowd commented Mar 12, 2023

Closing this as the next.js migration removed the commented out english sources.

@ovflowd ovflowd closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants