-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Remove English commented out code from translations #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey! Can you tell me more about this issue? |
EX: English text is copied into the translated documents like So if the English is updated, these are actually out of sync. |
@XhmikosR and @nschonni, I know this so far, it seems this is Korean and Japanese's habit. So we don't need to worry about them. |
Commenting the corresponding commit hash of English file may work. But transition will take time as it requires re-sync of all translation files. I personally don't have objections to having process transition. But I have to listen how @nodejs/nodejs-ko think. |
It's also a habit in pt_BR, at least in some files. |
We decided to go with CrowdIn approach here nodejs/i18n#72 and I'm now working on configuring it, so this issue will be fixed in near future. |
@nschonni I haven't followed the translations on his repo so if this is sorted or if it will be sorted, feel free to close this issue. |
Crowdin is hooked up now, but it's not really used. Primarily the changes comes as PRs to the repo |
Closing this as the next.js migration removed the commented out english sources. |
It seems it's common practice. We need another way for translators to follow the English files and know up to where they have translated. Maybe a simple HTML comment with the hash and then they can compare after that and see the diff.
Right now, many translations follow this practice which results in ~2x lines. All this does not come for free and it's bloating the codebase IMO.
Also, there's #2450.
The text was updated successfully, but these errors were encountered: