Skip to content

Document the dependency on libbrotli in the online documentation #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilyanpalauzov opened this issue Jun 23, 2020 · 6 comments
Closed

Comments

@dilyanpalauzov
Copy link

NodeJS can be built with bundled libbrotly or with --shared-brotli.

Document the dependency on libbrotli at https://nodejs.org/en/docs/meta/topics/dependencies/ .

@Trott Trott transferred this issue from nodejs/node Jun 24, 2020
@nschonni
Copy link
Member

@Trott why did you transfer the issue over here? That page is part of the docs in the node repo

@Trott
Copy link
Member

Trott commented Jun 25, 2020

@Trott why did you transfer the issue over here? That page is part of the docs in the node repo

It's in this repo: https://github.com/nodejs/nodejs.org/blob/d0be2aeef14e089b5afbc0bceb6b7cf9bf578c46/locale/en/docs/meta/topics/dependencies.md

@nschonni
Copy link
Member

👍 thanks, I was mixing up the api and docs folders

@MylesBorins
Copy link
Contributor

There's actually quite a few dependencies we are missing there. I think we might want to just remove this.

Thoughts?

@Trott
Copy link
Member

Trott commented Jun 26, 2020

There's actually quite a few dependencies we are missing there. I think we might want to just remove this.

Thoughts?

+1. It's hard to know what the purpose of this page is. None of these are dependencies you need to install to run Node.js. So this is more appropriately in the build docs in the main repo. And if we update it, it will just go out of date again.

@bmuenzenmeyer
Copy link
Collaborator

closing this. #5480 resolved the problem by linking to an up to date source over the the nodejs/node repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants