Skip to content

Sentry lazy loading in browser is incorrect #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r34son opened this issue Apr 7, 2024 · 3 comments · Fixed by #6634
Closed

Sentry lazy loading in browser is incorrect #6621

r34son opened this issue Apr 7, 2024 · 3 comments · Fixed by #6634

Comments

@r34son
Copy link
Contributor

r34son commented Apr 7, 2024

Enter your suggestions in details:

Related getsentry/sentry-javascript#11460
@mikeesto
Copy link
Member

mikeesto commented Apr 7, 2024

Hi, could you please add some more info about how this relates to nodejs.org?

@r34son
Copy link
Contributor Author

r34son commented Apr 7, 2024

https://github.com/nodejs/nodejs.org/blob/main/sentry.client.config.ts

You are trying to lazy load some sentry integrations, but it's incorrect. Take a look to the linked issue.

@bmuenzenmeyer
Copy link
Collaborator

@r34son nice research and work with Sentry on this one; care to send a PR our way?

r34son added a commit to r34son/nodejs.org that referenced this issue Apr 9, 2024
@r34son
fix: lazy load sentry integrations
b4868f6 
Closes nodejs#6621

Signed-off-by: Iakhub Seitasanov <[email protected]>
@r34son r34son mentioned this issue Apr 9, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 15, 2024
@r34son
FIx sentry integrations lazy loading (#6634)
de12484 
* fix: lazy load sentry integrations

Closes #6621

Signed-off-by: Iakhub Seitasanov <[email protected]>

* fix: remove deprecated sentry api

---------

Signed-off-by: Iakhub Seitasanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIx sentry integrations lazy loading r34son/nodejs.org
3 participants
@bmuenzenmeyer @mikeesto @r34son