Skip to content

Fix typo #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2017
Merged

Fix typo #1101

merged 2 commits into from
Jan 14, 2017

Conversation

piperchester
Copy link
Contributor

No description provided.

@lpinca
Copy link
Member

lpinca commented Jan 13, 2017

Not a native speaker but I think the original is also ok?
Anyway I'm fine with the change.

@ryanmurakami
Copy link
Contributor

The original was not correct grammatically, but using a semi colon instead just makes the sentence kind of difficult to read. Maybe a transition word like 'and' could be added to make it smoother?

@piperchester
Copy link
Contributor Author

Reading it over, I feel like even a period would be best for flow. Thoughts?

@ryanmurakami
Copy link
Contributor

@piperchester Yeah, I think that would be better.

@piperchester
Copy link
Contributor Author

@ryanmurakami made the change 😄

@ryanmurakami
Copy link
Contributor

@piperchester Awesome! Thanks!

@ryanmurakami ryanmurakami merged commit edd9de7 into nodejs:master Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piperchester @lpinca @ryanmurakami