Skip to content

chore: update card image #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 11, 2017
Merged

chore: update card image #1512

1 commit merged into from
Dec 11, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Dec 11, 2017

The current png has no margins and doesn't look great.

I've created a new png that is no longer transparent and has margins.
Should look nicer

edit:

worth mentioning this retains the exact same proportions as before, if there are better proportions for a card I can use the svg to make an entirely new image

The current png has no margins and doesn't look great.

I've created a new png that is no longer transparent and has margins.
Should look nicer
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement, Myles <3

@ghost ghost merged commit 6074870 into nodejs:master Dec 11, 2017
@MylesBorins
Copy link
Contributor Author

For posterity this is how it looks now

screen shot 2017-12-12 at 1 26 19 am

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants