Skip to content

[Localization] Modify a Chinese character from traditional one to simplified one #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 13, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2018

To union the Chinese characters in uion, change from to .

BTW:

1)Any plans for traditional Chinese?
2)Where' are previous , next and by (in site.json) shown in the current website page? I cannot find them anywhere. Should they be removed?

@laosb
Copy link

laosb commented Jun 12, 2018

Traditional Chinese differs between Taiwan, Hong Kong and Macau. For now the only (seemed inactive) group of Traditional Chinese users is @nodejs/nodejs-tw. You may try to contact them if you're interested in having Traditional Chinese.

For those words, I'm not that familiar with this repo and I have no experience about that. Simply don't touch it if you are not sure.

For this PR, LGTM.

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, would you please add back that empty line?

@ghost
Copy link
Author

ghost commented Jun 13, 2018

Added, I didn't notice that my VSC can re-format my codes when saving. Sorry for inconvenience.

@dca
Copy link
Contributor

dca commented Jun 13, 2018

LGTM!

@fhemberger
Copy link
Contributor

@Maledong "previous"/"next" are for the guides (we had to remove it temporarily), "by" for the blog posts (e.g. "Node v8.11.3 (LTS) by Evan Lucas, 2018-06-12").

@fhemberger fhemberger merged commit e315d10 into nodejs:master Jun 13, 2018
@ghost
Copy link
Author

ghost commented Jun 14, 2018

@fhemberger
I've synchronized my codes with yours and it seems we still have "previous" and "next" left. Can I help you to remove them out now?
useless

@laosb & @dca
I don't think we need to translate by, because this is well-known to all. On the other hand, if you see ja-jp and zh-TW. It still remains by itself:
by

If you all insist translating by, it should be translated to instead of in Chinese, according to fhemberger said :)

BTW:
Are all 回報 should be 匯報 in all zh-TW in site.json?

@fhemberger
Copy link
Contributor

@Maledong I'd like to keep those fields in for the moment. Thank you!

@ghost
Copy link
Author

ghost commented Jun 14, 2018

OK. Thanks for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants