Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2018

Just like 631e5da#diff-c73a453a788f6d072e426628a94d129f.
We should add this for Chinese version in both Tranditional and
Simplified one.

PS:@nodejs/localization, you can also do translations if you are free :)

Just like
631e5da#diff-c73a453a788f6d072e426628a94d129f.
We should add this for Chinese version in both Tranditional and
Simplified one.
@ghost ghost requested a review from ZYSzys December 16, 2018 05:10
ZYSzys and others added 2 commits December 16, 2018 13:28
Agreed

Co-Authored-By: Maledong <[email protected]>
Agreed

Co-Authored-By: Maledong <[email protected]>
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 0831f69 into nodejs:master Dec 16, 2018
@ghost ghost deleted the AddEditOnGitTrans branch December 16, 2018 05:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants