Split npm scripts and run them in parallel #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
changed the title
SEWeiTung
approved these changes
Sep 7, 2019
|
Seems fine to me. |
|
@Trott how about moving |
👍 |
It simplifies things.
|
Cool, I'll make this change in another PR. |
Merged
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first approach at addressing #2463.
Other changes:
--fixfromstandardbecause on CI this didn't make the build fail. One can still donpm run test:lint:js -- --fixlocally if they want totest:lintscripts in parallelI still think we should move
npm run buildoutside of tape and just run this before test. Build warnings aren't shown in tapeFixes #2463