Replace i with em.
#2522
Merged
Replace i with em.
#2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly for consistency and being more schematically correct.
Aissaoui-Ahmed
approved these changes
Sep 7, 2019
Trott
previously requested changes
Sep 7, 2019
Trott
dismissed
their stale review
Actually, I'm not going to block this. I don't actually care that much, plus we probably want people to use the markdown equivalents anyway. This is especially totally fine with me if it's supposed to be a step towards eliminating the i, em, b, and strong HTML elements from our markdown entirely
Trott
approved these changes
Sep 7, 2019
|
Yeah, the plan is to clean up the elements as we can. |
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for consistency and being more schematically correct.