replace custom logic in loadVersions with node-version-data package #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ | |||
| "metalsmith-serve": "0.0.3", | |||
| "metalsmith-stylus": "1.0.0", | |||
| "ncp": "2.0.0", | |||
| "node-version-data": "~1.0.0", | |||
There was a problem hiding this comment.
do we need to pin to an exact version here? It seems like that is the current way of doing it.
There was a problem hiding this comment.
Yes, we are using greenkeeperio here. example: #279
There was a problem hiding this comment.
whoops, didn't realise! fixed
|
LGTM |
stevemao
added a commit
that referenced
this pull request
Oct 27, 2015
replace custom logic in loadVersions with node-version-data package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm encouraging the npm team to use this same package to fetch the data they need for mapping node to npm versions