Use fs.access instead of fs.existsSync
#350
Conversation
| var fs = require('fs') | ||
| const basePath = path.join(__dirname, '..', '..', 'locale', 'en', 'blog', 'weekly-updates') | ||
| const client = github.client() | ||
| const evRepo = client.repo('nodejs/evangelism') |
There was a problem hiding this comment.
Since you are refactoring, you can directly create evRepo without those intermediate requires.
lpinca
force-pushed
the
use/fs.access
branch
from
52d8b33 to
285a901
Compare
|
Change LGTM. Do you know why CI is not run for this PR? |
|
No clue. |
lpinca
force-pushed
the
use/fs.access
branch
from
285a901 to
cfea8c1
Compare
|
@thefourtheye please check again. |
|
LGTM. Some error handling on the HTTPS request and file writing would be nice, but that could be another PR. |
| https.get(downloadUrl, function (response) { | ||
| response.pipe(outputFile) | ||
| https.get(file.download_url, function (response) { | ||
| response.pipe(fs.createWriteStream(filePath)) |
There was a problem hiding this comment.
Would it be better if we notified the user once the downloading is complete?
There was a problem hiding this comment.
Any idea on what kind of message? Something like this?
console.log(`Weekly Update ${filePath} downloaded.`);There was a problem hiding this comment.
We already log the filePath. So wouldn't Download completed be better?
There was a problem hiding this comment.
It would help to understand what file the message refers to, otherwise with multiple files, it can be confusing, but yes a simple "Download completed" can work too.
lpinca
force-pushed
the
use/fs.access
branch
from
cfea8c1 to
fdedf38
Compare
|
@phillipj do you know why CI is not run for this PR? |
| https.get(downloadUrl, function (response) { | ||
| response.pipe(outputFile) | ||
| https.get(file.download_url, function (response) { | ||
| console.log(`Weekly Update ${filePath} downloaded.`) |
There was a problem hiding this comment.
@thefourtheye If you feel strong about using only "Download completed.", I'll change this.
There was a problem hiding this comment.
This actually should have been
response.on('end', () => console.log(`Weekly Update ${filePath} downloaded.`))
|
@thefourtheye no idea why it doesn't show inline in the PR.. These commits are visible in the Travis/new.nodejs.org build history though, might be a github hickup? |
|
PTAL. |
|
Still looks fine to me. But I would be confident if CI ran. |
|
https://travis-ci.org/nodejs/new.nodejs.org/builds/90492242 is the build for @lpinca latest commit ba338a5 |
Use `fs.access` instead of `fs.existsSync`
|
Cool. Merged now. 👍 Thanks @phillipj :-) |
The reason behind this change is that
fs.existsand its sync version are deprecated.