Skip to content

fix changelog links for new 0.12 and 0.10 releases #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2016
Merged

fix changelog links for new 0.12 and 0.10 releases #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/helpers/changeloglink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,10 @@ module.exports = function (version) {
return `https://github.com/nodejs/node/blob/${version}/CHANGELOG.md`
}

// 0.12.8+ and 0.10.41+ releases come from the new repo
if (semver.satisfies(version, '~0.12.8 || ~0.10.41')) {
return `https://github.com/nodejs/node/blob/${version}/ChangeLog`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this not need to be ChangeLog.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thealphanerd It was not markdown until io.js v1.0.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad... I was misunderstanding what the bug was. nothing to see here :D

}

return `https://github.com/nodejs/node-v0.x-archive/blob/${version}/ChangeLog`
}