Skip to content

Fix breadcrumbs not updating #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 6, 2024
Merged

Fix breadcrumbs not updating #6431

merged 9 commits into from
Mar 6, 2024

Conversation

yanggggjie
Copy link
Contributor

@yanggggjie yanggggjie commented Mar 4, 2024 •
edited
Loading

Description

fix: #6365

Validation

before

image

after

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@yanggggjie yanggggjie requested a review from a team as a code owner March 4, 2024 12:02
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 6, 2024 0:06am

ovflowd
ovflowd reviewed Mar 4, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 4, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 4, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 4, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 5, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 5, 2024
View reviewed changes
ovflowd
ovflowd reviewed Mar 5, 2024
View reviewed changes
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 5, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 92 🟢 100 🟢 92 🔗

ovflowd
ovflowd approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution, and for going over the feedback :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
 79.63% (434/545) 79.65% (137/172) 71.02% (76/107)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.451s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 5, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 5, 2024
@ovflowd ovflowd merged commit 2df76dc into nodejs:main Mar 6, 2024
@yanggggjie yanggggjie deleted the fix-breadcrumbs-not-updating branch March 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs not updating on Learn pages
2 participants
@yanggggjie @ovflowd