Skip to content

fix: proper release status #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: proper release status #6603

merged 1 commit into from
Apr 3, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Apr 2, 2024

Description

As per recommendation of the Node.js releasers, we should simplify our status stamping and ignore "Maintenance" statuses and only consider EOL statuses.

Validation

LTS and Current versions should still render properly and all the logic should be working as expected

Related Issues

Fixes #6584

@ovflowd ovflowd requested a review from a team as a code owner April 2, 2024 10:28
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 2, 2024 10:29am

@ovflowd
Copy link
Member Author

ovflowd commented Apr 2, 2024

cc @targos

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 96 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 96 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
89.96% (574/638) 76.1% (172/226) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 5.368s ⏱️

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@ovflowd ovflowd added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 2d1b54a Apr 3, 2024
@ovflowd ovflowd deleted the fix/proper-release-status branch April 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage LTS link downloads non LTS version
6 participants