Skip to content

fix: explain that example is not deterministic #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Apr 3, 2024

The example of asynchronous code is not deterministic and can produce differ results from run to run. It is not a bug in the documentation.

cc @ovflowd

#6606 (comment)

@lemire lemire requested a review from a team as a code owner April 3, 2024 18:20
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 3, 2024 6:22pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 96 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 96 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
89.96% (574/638) 76.1% (172/226) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 5.373s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Apr 5, 2024
Merged via the queue into nodejs:main with commit f8cb833 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants