fix: Bitness type in dropdown #6614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Just a quick headsup. On Firefox Bitness information comes as number when it is x64/x86 (as 64 and 86). Whilst on Chrome it comes as a string So just, let's please ensure this works both on firefox and chrome 😅 |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
ovflowd
reviewed
Apr 9, 2024
| if (currentBitnessExcluded && nonExcludedBitness) { | ||
| // We set it as a Number for cases where it is 64 or 86 otherwise we are | ||
| // setting it as a string (ARMv7, ARMv6, etc.) | ||
| if (Number.isNaN(Number(nonExcludedBitness)) === false) { |
There was a problem hiding this comment.
Could this be transformed into:
const numericBitness = Number(nonExcludedBitness);
setBitness(
numericBitness.toString() === nonExcludedBitness
? numericBitness
: nonExcludedBitness
);I'm not sure if the value actually needs to be a number? If not:
const numericBitness = Number(nonExcludedBitness).toString();
setBitness(
numericBitness === nonExcludedBitness
? numericBitness
: nonExcludedBitness
);
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ovflowd
approved these changes
Apr 9, 2024
AugustinMauroy
approved these changes
Apr 9, 2024
aymen94
approved these changes
Apr 9, 2024
|
FYI @canerakdas is OOO for a few days I'll merge the PR as it is, and then @canerakdas can iterate on my feedback afterwards. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the default bitness information was excluded and non-excluded bitness existed, we were assigning bitness information as a string by default. With this PR, it was possible to assign numbers such as 86 ,64 or strings such as "arm64" or "armv7l" depending on the type of bitness selected.
With this PR, we aim to create the correct link even when the default bitness is disabled from the
getNodeDownloadUrlmethod. I will check if we can prepare test cases to check these links 👀Validation
In the preview, download links should be correct
Related Issues
Fixes #6613
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.