content(learn): update resources about typescript #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bmuenzenmeyer merged 10 commits into main from content(learn)-typescript

Sep 16, 2024

Member

AugustinMauroy commented Jul 28, 2024

Description

Updating ressources about typescript

Validation

redirect should work
example should be correct

Related Issues

nodejs/node#53725 (comment)


          content(learn): update ressources about typescript

c53ed00

vercel bot commented Jul 28, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Sep 14, 2024 1:19pm


          adding important note

dfe4e40

AugustinMauroy marked this pull request as ready for review

July 28, 2024 19:15

AugustinMauroy requested a review from a team as a code owner

July 28, 2024 19:15

Member Author

AugustinMauroy commented Jul 28, 2024

CC @marco-ippolito 👋
BTW: thank you for everything you've done

vercel bot deployed to Preview

July 28, 2024 19:16

View deployment

AugustinMauroy added the content label

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run.md Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run.md Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/transpile.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/transpile.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/transpile.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/transpile.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/transpile.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview

July 30, 2024 08:53

View deployment

marco-ippolito changed the title ~~content(learn): update ressources about typescript~~ content(learn): update resources about typescript


          content(learn): update from feedback

215a5c7

Co-Authored-By: Antoine du Hamel <[email protected]>

AugustinMauroy force-pushed the content(learn)-typescript branch from 9f0644b to 215a5c7 Compare

July 30, 2024 08:55

vercel bot deployed to Preview

July 30, 2024 08:57

View deployment


          content(learn): remove global install of tsc

96bd205

AugustinMauroy commented

View reviewed changes

apps/site/pages/en/learn/typescript/run.md Show resolved Hide resolved

AugustinMauroy mentioned this pull request

doc: Add new section about native typescript support. #6984

Closed


          update

b6bcd40

vercel bot deployed to Preview

August 9, 2024 09:47

View deployment

aagamezl reviewed

View reviewed changes

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

apps/site/i18n/locales/en.json Outdated Show resolved Hide resolved

mikeesto mentioned this pull request

TypeScript article: Add experimental-strip-types note #7030

Closed

5 tasks


          update

461bbd5

vercel bot deployed to Preview

September 12, 2024 12:32

View deployment

AugustinMauroy requested a review from aduh95

September 13, 2024 07:46

AugustinMauroy added the learn label

bmuenzenmeyer reviewed

View reviewed changes

Collaborator

bmuenzenmeyer left a comment

overall this is an excellent primer, thanks @AugustinMauroy

I gave it a pass with a critical eye.

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run-natively.md Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run.md Outdated Show resolved Hide resolved

apps/site/pages/en/learn/typescript/run.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview

September 14, 2024 13:01

View deployment


          Update from feedback

43f5c59

Co-Authored-By: Brian Muenzenmeyer <[email protected]>

AugustinMauroy force-pushed the content(learn)-typescript branch from acf8153 to 43f5c59 Compare

September 14, 2024 13:13

vercel bot deployed to Preview

September 14, 2024 13:14

View deployment

Member Author

AugustinMauroy commented Sep 14, 2024

@bmuenzenmeyer I've applied your review. Thanks a lot.


          Merge branch 'main' into content(learn)-typescript

725e8a1

vercel bot deployed to Preview

September 14, 2024 13:19

View deployment

bmuenzenmeyer approved these changes

View reviewed changes

bmuenzenmeyer added the github_actions:pull-request label

github-actions bot removed the github_actions:pull-request label

bmuenzenmeyer deployed to Storybook

September 15, 2024 02:04

— with

GitHub Actions View deployment

Contributor

github-actions bot commented Sep 15, 2024 •

edited

Loading

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 87	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 100	🟢 92	🔗

Contributor

github-actions bot commented Sep 15, 2024

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.47% (589/651)	76.29% (177/232)	94.35% (117/124)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
131	0 💤	0 ❌	0 🔥	5.265s ⏱️

marco-ippolito approved these changes

View reviewed changes

aymen94 approved these changes

View reviewed changes

bmuenzenmeyer added this pull request to the merge queue

Merged via the queue into main with commit d164714

15 checks passed

bmuenzenmeyer deleted the content(learn)-typescript branch

September 16, 2024 12:14

joeeames pushed a commit to joeeames/nodejs.org that referenced this pull request


          content(learn): update resources about typescript (nodejs#6951)

0d8b26f

* content(learn): update ressources about typescript

* adding important note

* content(learn): update from feedback

Co-Authored-By: Antoine du Hamel <[email protected]>

* content(learn): remove global install of tsc

* fix fails from github copilot

fix fails from github copilot

* fix: remove old stuff from navigation

* update

* update

* Update from feedback

Co-Authored-By: Brian Muenzenmeyer <[email protected]>

---------

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Brian Muenzenmeyer <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bmuenzenmeyer bmuenzenmeyer approved these changes

aymen94 aymen94 approved these changes

marco-ippolito marco-ippolito approved these changes

aduh95 Awaiting requested review from aduh95

+1 more reviewer

aagamezl aagamezl left review comments

Labels