-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(chromatic): run if a user adds the label to a Dependabot PR #7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the behavior for Dependabot PRs by allowing maintainers to manually add a trigger label to run Storybook builds and visual regression tests.
- Modified workflow condition to target Dependabot PRs
- Removed branch name exclusion and added an actor check
Signed-off-by: Aviv Keller <[email protected]>
Another alternative is to check the branch ref, like @MattIPv4 mentioned, but I think this solution allows for us to run Storybook on various Dependabot PRs where they might be needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7722 +/- ##
==========================================
- Coverage 74.82% 74.81% -0.02%
==========================================
Files 98 98
Lines 7878 7878
Branches 199 199
==========================================
- Hits 5895 5894 -1
- Misses 1982 1983 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checking the actor was definitely my preferred approach 👍 |
Fast tracking! Merge when ready |
Fixes #7709
Maintainers can now manually re-add the trigger label to Dependabot PRs to run Storybook if needed. These workflows still won’t run automatically, as the upgrades aren’t always necessary.