Skip to content

Conversation

avivkeller
Copy link
Member

Fixes #7709


Maintainers can now manually re-add the trigger label to Dependabot PRs to run Storybook if needed. These workflows still won’t run automatically, as the upgrades aren’t always necessary.

@Copilot Copilot AI review requested due to automatic review settings May 3, 2025 18:44
@avivkeller avivkeller requested a review from a team as a code owner May 3, 2025 18:44
Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) Visit Preview May 3, 2025 6:46pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the behavior for Dependabot PRs by allowing maintainers to manually add a trigger label to run Storybook builds and visual regression tests.

  • Modified workflow condition to target Dependabot PRs
  • Removed branch name exclusion and added an actor check

Signed-off-by: Aviv Keller <[email protected]>
@avivkeller
Copy link
Member Author

Another alternative is to check the branch ref, like @MattIPv4 mentioned, but I think this solution allows for us to run Storybook on various Dependabot PRs where they might be needed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (b663493) to head (6bad1cb).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7722      +/-   ##
==========================================
- Coverage   74.82%   74.81%   -0.02%     
==========================================
  Files          98       98              
  Lines        7878     7878              
  Branches      199      199              
==========================================
- Hits         5895     5894       -1     
- Misses       1982     1983       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MattIPv4
Copy link
Member

MattIPv4 commented May 3, 2025

Another alternative is to check the branch ref, like @MattIPv4 mentioned, but I think this solution allows for us to run Storybook on various Dependabot PRs where they might be needed.

Checking the actor was definitely my preferred approach 👍

@avivkeller avivkeller added the fast-track Fast Tracking PRs label May 4, 2025
@avivkeller
Copy link
Member Author

Fast tracking! Merge when ready

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label May 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 4, 2025
@avivkeller avivkeller added this pull request to the merge queue May 4, 2025
Merged via the queue into main with commit b551775 May 4, 2025
21 checks passed
@avivkeller avivkeller deleted the run-on-manual-dependabot-dispatch branch May 4, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Chromatic workflow to be run for Dependabot
6 participants