chore(🏳️🌈): logo #7861
Merged
chore(🏳️🌈): logo #7861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the site's configuration by adding a new logo variant property that reflects a pride theme.
- Added a new "logoVariant" property with the value "pride" in the configuration file.
Comments suppressed due to low confidence (1)
apps/site/site.json:6
- [nitpick] Consider adding comments or documentation to explain the usage and expected values for the new 'logoVariant' property, ensuring that maintainers and other developers understand the context of this change.
"logoVariant": "pride",
|
@nodejs/tsc |
|
Do we have the ability to update the favicon to the pride variant as well? |
MattIPv4
approved these changes
Jun 12, 2025
avivkeller
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
|
Fast tracking, this can land once TSC approval |
bmuenzenmeyer
approved these changes
Jun 12, 2025
legendecas
approved these changes
Jun 12, 2025
canerakdas
approved these changes
Jun 12, 2025
LiviaMedeiros
approved these changes
Jun 12, 2025
jasnell
approved these changes
Jun 12, 2025
|
Could you please attach the relevant issue on the PR description? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the vote, available at nodejs/collaborators-public-votes#17
See #6802