Skip to content

Conversation

canerakdas
Copy link
Member

Description

I’ve made some small refactors on the download archive page, per related comments here;
#7794 (comment)
#7794 (comment)

In addition to this PR, I’ve also added the changelog of the displayed version to the section where we provide version-related information. Since this information is valuable, I believe placing the links higher up makes more sense

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 21:52
@canerakdas canerakdas requested a review from a team as a code owner September 1, 2025 21:52
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 3, 2025 7:32pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the download archive page by removing unnecessary validation checks and error handling that are deemed redundant given the context of how the page is accessed. The changes include simplifying the version extraction logic and updating the UI to provide more prominent links to version-specific information.

  • Simplified extractVersionFromPath function by removing null checks and version format validation
  • Removed error handling in WithDownloadArchive component that was checking for null versions
  • Added changelog and blog post links higher up in the archive page UI

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
apps/site/util/download/archive.tsx Simplified version extraction by removing validation checks and making the parameter non-optional
apps/site/components/withDownloadArchive.tsx Removed null checks, unused imports, and simplified version matching logic
apps/site/pages/en/download/archive/index.mdx Added changelog and blog post links to provide better access to version information

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.55%. Comparing base (fd6b7e6) to head (03b2a93).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8134      +/-   ##
==========================================
- Coverage   76.60%   76.55%   -0.05%     
==========================================
  Files         115      115              
  Lines        9595     9602       +7     
  Branches      321      323       +2     
==========================================
+ Hits         7350     7351       +1     
- Misses       2244     2250       +6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canerakdas
Copy link
Member Author

I'll check why the /en/download/archive is returns to 500

@canerakdas canerakdas marked this pull request as ready for review September 3, 2025 18:38
@canerakdas canerakdas requested a review from a team as a code owner September 3, 2025 18:38
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ovflowd ovflowd added this pull request to the merge queue Sep 7, 2025
Merged via the queue into nodejs:main with commit 63a013f Sep 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants