Skip to content

Simplify package.json #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Simplify package.json #963

merged 1 commit into from
Oct 28, 2016

Conversation

zlatanvasovic
Copy link
Contributor

  1. There's a shorter owner/repository syntax for GitHub repositories according to npm docs.
  2. normalize-package-data says bugs are needless if you've specified the repository.

@lpinca
Copy link
Member

lpinca commented Oct 14, 2016

+0, I see no real value in doing this.

@zlatanvasovic
Copy link
Contributor Author

Software development is based on constant improvement. If people reacted like you did now, we'd still be stuck on writing programs in machine language.

@lpinca
Copy link
Member

lpinca commented Oct 14, 2016

@zdroid I'm sorry if my comment looks like a judgment, that wasn't my intention.
I'm not opposing to this change (note the +0) but I can't see how it is useful.

@pin3da
Copy link
Contributor

pin3da commented Oct 14, 2016

@zdroid In my opinion is less readable because it hides information.

btw, I don't think that '+0' is a bad opinion, is just appointing that there is no improvement in doing that.

@zlatanvasovic
Copy link
Contributor Author

zlatanvasovic commented Oct 14, 2016

It doesn't hide any information. You don't need to be told again you're using a git repository hosted on https://github.com.

@sotayamashita
Copy link
Contributor

sotayamashita commented Oct 23, 2016

@zdroid

  1. There's a shorter owner/repository syntax for GitHub repositories according to npm docs.

If it is an optional choice, I think we do not have to change it.

  1. normalize-package-data says bugs are needless if you've specified the repository.

I agree with this to follow the standard.

@zlatanvasovic
Copy link
Contributor Author

zlatanvasovic commented Oct 23, 2016

@sotayamashita Basically, both of those are already standard, especially the first. They're widely accepted by the npm community.

@sotayamashita
Copy link
Contributor

@zdroid I am sorry and I do not know it. If both of those are, I think it looks good

@ryanmurakami
Copy link
Contributor

+1
I like the reduction of boilerplate in a package.json. I think the assumptions of where the source code is stored is widely understood as being Github, so removing that just makes it cleaner and easier to read.

@zlatanvasovic zlatanvasovic merged commit 41ae832 into nodejs:master Oct 28, 2016
@zlatanvasovic zlatanvasovic deleted the package.json branch October 28, 2016 19:56
@zlatanvasovic
Copy link
Contributor Author

Merging this, as opinions were positive and the proposed changes don't affect general build at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants