Fix timestamps and add IOCTL support for nbytes #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds functionality to the uvwasi poll_oneoff implementation by reporting the number of bytes available to read for file descriptors. It uses ioctl with FIONREAD on Unix-like systems and ioctlsocket for socket types on Windows to properly populate the nbytes field in FD_READ events. Additionally, it adds the necessary system headers for these ioctl calls with appropriate platform-specific handling. The change helps applications know exactly how many bytes they can read without blocking, improving performance by allowing them to allocate buffers of the correct size.
|
The cross-platform approach with appropriate handling for both Unix and Windows is well-implemented, particularly the special consideration for Windows which doesn't support FIONREAD for non-socket descriptors. The error handling also looks robust, gracefully falling back to zero bytes when ioctl operations fail. |
|
@mmori7 the CI is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds functionality to the uvwasi poll_oneoff implementation by reporting the number of bytes available to read for file descriptors. It uses ioctl with FIONREAD on Unix-like systems and ioctlsocket for socket types on Windows to properly populate the nbytes field in FD_READ events. Additionally, it adds the necessary system headers for these ioctl calls with appropriate platform-specific handling. The change helps applications know exactly how many bytes they can read without blocking, improving performance by allowing them to allocate buffers of the correct size.