Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Create monitoring-node-js-overview.md #91

Closed
wants to merge 1 commit into from

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Sep 13, 2018

Creates an overview file for Monitoring docs.

Creates an overview file for Monitoring docs.
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sagirk sagirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@sagirk
Copy link
Contributor

sagirk commented Mar 6, 2019

@bnb monitoring-node-js-overview.md is currently placed in documentation/0000-template/. Not sure if that is where we still want it to go (?).

To be consistent with the rest of the content, would it be appropriate to create a new folder 0056-monitoring-node-js-overview, rename this file to index.md and move it there?

Also, the format for metadata at the top has changed in the newer handbook content. So, we may need to update that too.

@sagirk
Copy link
Contributor

sagirk commented Mar 6, 2019

Metadata format example, as will be consumed by nodejs.dev:

---
title: An introduction to the npm package manager
description: 'A quick guide to npm, the powerful package manager key to the success of Node.js. In January 2017 over 350000 packages were reported being listed in the npm registry, making it the biggest single language code repository on Earth, and you can be sure there is a package for (almost!) everything.'
authors: flaviocopes
section: Getting Started
---

@keywordnew
Copy link
Contributor

keywordnew commented May 9, 2019

@sagirk I was about to merge this because it has enough reviews. I'm unclear on whether the later comment was meant to be blocking.

@Trott
Copy link
Member

Trott commented Apr 22, 2023

I've unarchived this repo so I can close all PRs and issues before re-archiving.

@Trott Trott closed this Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants