Skip to content

Update min recommended NodeJs text #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Sep 16, 2016
Merged

Update min recommended NodeJs text #529

merged 2 commits into from Sep 16, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2016

Following from PR #528, the 'minimum NodeJs version' has been rephrased to indicate the first step in troubleshooting problems. Also added a link to discussions added for further help.

Minimum NodeJs version rephrased to indicate first step in
troubleshooting problems. Link to discussions added for further help.
Copy link
Contributor

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a while this sentence will not be properly translated to other languages and be shown in English. Do you think you can make the language easier (encountering is a bit hard to grasp)

Changed version/troubleshooting text to use a similar syntax to the other help texts on the page (i.e. "Stuck? Ask a question..."); this should make it easier to translate.
@ghost
Copy link
Author

ghost commented Sep 16, 2016

@martinheidegger I've made some changes which simplify the language a bit; should be easier to translate and make the text a bit more helpful.

@martinheidegger martinheidegger merged commit 258fb4a into nodeschool:source Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants