Skip to content

Use latest CloudEvent API to eliminate transient axios dependency #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lance opened this issue Oct 5, 2020 · 1 comment · Fixed by #71
Closed

Use latest CloudEvent API to eliminate transient axios dependency #62

lance opened this issue Oct 5, 2020 · 1 comment · Fixed by #71

Comments

@lance
Copy link
Member

lance commented Oct 5, 2020 •
edited
Loading

/cc @lholmquist
@lholmquist
Copy link
Member

depends on cloudevents/sdk-javascript#348

lance added a commit to lance/faas-js-runtime that referenced this issue Nov 2, 2020
@lance
fix: reverse the parameter order when invoking
8a29476 
To make it possible for functions to easily act as both HTTP and CloudEvent
handler it's better to have any potential data as the second parameter.

This change also makes use of a new bit of the cloudevents API to receive an
incoming event, eliminating a transitive dependency on axios.

Fixes: nodeshift#62

Fixes: knative/func#194 (when updated in thetemplate)

Signed-off-by: Lance Ball <[email protected]>
@lance lance mentioned this issue Nov 2, 2020
Merged
@lance lance closed this as completed in #71 Nov 3, 2020
lance added a commit that referenced this issue Nov 3, 2020
@lance
fix: reverse the parameter order when invoking (#71)
df55e8a 
To make it possible for functions to easily act as both HTTP and CloudEvent
handler it's better to have any potential data as the second parameter.

This change also makes use of a new bit of the cloudevents API to receive an
incoming event, eliminating a transitive dependency on axios.

Fixes: #62

Fixes: knative/func#194 (when updated in thetemplate)

Signed-off-by: Lance Ball <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reverse the parameter order when invoking lance/faas-js-runtime
2 participants
@lance @lholmquist