Skip to content

Support for additional content types besides CloudEvents, application/json and text/plain #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lance opened this issue Oct 6, 2020 · 1 comment · Fixed by #112
Closed

Support for additional content types besides CloudEvents, application/json and text/plain #64

lance opened this issue Oct 6, 2020 · 1 comment · Fixed by #112
Labels
enhancement New feature or request

Comments

@lance
Copy link
Member

lance commented Oct 6, 2020

The underlying transport framework, fastify only provides content type parsing for application/json and text/plain. We already have a content type parser for application/json+cloudevent, but if the event data is anything other than text of JSON, the request will fail.

We should use Fastify's catch-all content type handler to deal with this.
@lance lance added the enhancement New feature or request label Oct 6, 2020
@lance
Copy link
Member Author

lance commented Dec 10, 2020

Depends on cloudevents/sdk-javascript#368

lance added a commit to lance/faas-js-runtime that referenced this issue Feb 1, 2022
@lance
feat: support binary data in cloudevents
3ddd647 
Depends on: cloudevents/sdk-javascript#468
Fixes: nodeshift#64

Signed-off-by: Lance Ball <[email protected]>
@lance lance mentioned this issue Feb 1, 2022
Merged
@lance lance closed this as completed in #112 Feb 9, 2022
lance added a commit that referenced this issue Feb 9, 2022
@lance
feat: support binary data in cloudevents (#112)
2ce6c05 
Depends on: cloudevents/sdk-javascript#468
Fixes: #64

Signed-off-by: Lance Ball <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support binary data in cloudevents lance/faas-js-runtime
1 participant
@lance