Fix PollLoop threading, add documentation, and split functionality in smaller methods #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of the internal clean-up.
KafkaReceiveris in need of a cleaner implementation, better internal naming, and documentation. This PR kick starts that effort, since this PR already contains too many changes. All subsequent changes will be isolated in PRs.KafkaReceivermight get renamed toKafkaSubscriberto match thePublishername, this can be done while gracefully migrating.The new threading model of the receiver allows more code to run on the user thread, while guaranteeing that as little as possible code runs on the receiver. It also temporarily added some development utilities to verify the threads during dev/testing.