Skip to content

Making sure to close FD and DIR on DTOR #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2021
Merged

Making sure to close FD and DIR on DTOR #6668

merged 1 commit into from
Jul 18, 2021

Conversation

jeniawhite
Copy link
Contributor

Explain the changes

  1. Added a close inside the DTOR for FileWrap and DirWrap
  2. This is due to the NodeJS issue stream: pipeline should error if any stream is destroyed nodejs/node#36674 and the behavior of finally with orphan Promises

Issues: Fixed #xxx / Gap #xxx

  1. stream: pipeline should error if any stream is destroyed nodejs/node#36674

Testing Instructions:

@jeniawhite jeniawhite merged commit e723b47 into noobaa:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@nimrod-becker nimrod-becker Awaiting requested review from nimrod-becker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeniawhite @guymguym @nimrod-becker